]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
packet: read num_members once in packet_rcv_fanout()
authorEric Dumazet <edumazet@google.com>
Tue, 16 Jun 2015 14:59:11 +0000 (07:59 -0700)
committerZefan Li <lizefan@huawei.com>
Thu, 22 Oct 2015 01:20:05 +0000 (09:20 +0800)
commit2fb9a78c44b0801fb17f3f73f553b8416b96abe0
tree0fa3049732e55c3340dbf3a1048ce775b47c55b8
parentb80954b45832fbd665c2a8bc545601716942ce78
packet: read num_members once in packet_rcv_fanout()

commit f98f4514d07871da7a113dd9e3e330743fd70ae4 upstream.

We need to tell compiler it must not read f->num_members multiple
times. Otherwise testing if num is not zero is flaky, and we could
attempt an invalid divide by 0 in fanout_demux_cpu()

Note bug was present in packet_rcv_fanout_hash() and
packet_rcv_fanout_lb() but final 3.1 had a simple location
after commit 95ec3eb417115fb ("packet: Add 'cpu' fanout policy.")

Fixes: dc99f600698dc ("packet: Add fanout support.")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Willem de Bruijn <willemb@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
[lizf: Backported to 3.4: use ACCESS_ONCE() instead of READ_ONCE()]
Signed-off-by: Zefan Li <lizefan@huawei.com>
net/packet/af_packet.c