]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/tidss: Fix enable/disable order
authorTomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Fri, 5 Dec 2025 09:51:51 +0000 (11:51 +0200)
committerLinus Walleij <linusw@kernel.org>
Sat, 3 Jan 2026 19:08:24 +0000 (20:08 +0100)
commit2fc04340cf30d7960eed2525d26ffb8905aca02b
tree89c952e359a5b99ca64a96ebeb5e8d953aec1769
parentd1c7dc57ff2400b141e6582a8d2dc5170108cf81
drm/tidss: Fix enable/disable order

TI's OLDI and DSI encoders need to be set up before the crtc is enabled,
but the DRM helpers will enable the crtc first. This causes various
issues on TI platforms, like visual artifacts or crtc sync lost
warnings.

Thus drm_atomic_helper_commit_modeset_enables() and
drm_atomic_helper_commit_modeset_disables() cannot be used, as they
enable the crtc before bridges' pre-enable, and disable the crtc after
bridges' post-disable.

Open code the drm_atomic_helper_commit_modeset_enables() and
drm_atomic_helper_commit_modeset_disables(), and first call the bridges'
pre-enables, then crtc enable, then bridges' post-enable (and vice versa
for disable).

Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ideasonboard.com>
Cc: stable@vger.kernel.org # v6.17+
Fixes: c9b1150a68d9 ("drm/atomic-helper: Re-order bridge chain pre-enable and post-disable")
Reviewed-by: Aradhya Bhatia <aradhya.bhatia@linux.dev>
Reviewed-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Linus Walleij <linusw@kernel.org>
Tested-by: Linus Walleij <linusw@kernel.org>
Signed-off-by: Linus Walleij <linusw@kernel.org>
Link: https://patch.msgid.link/20251205-drm-seq-fix-v1-4-fda68fa1b3de@ideasonboard.com
drivers/gpu/drm/tidss/tidss_kms.c