]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Remove incorrect assertion for INSERT in logical replication's publisher
authorMichael Paquier <michael@paquier.xyz>
Sun, 12 Jan 2020 13:45:17 +0000 (22:45 +0900)
committerMichael Paquier <michael@paquier.xyz>
Sun, 12 Jan 2020 13:45:17 +0000 (22:45 +0900)
commit30104eca885637ecce1b48c958cf6ec733b93a3d
tree57e4827edc366ef723bd9fc60a223f6e43a52235
parentcb977424532f20fae65f2e58ac901286a2482b24
Remove incorrect assertion for INSERT in logical replication's publisher

On the publisher, it was assumed that an INSERT change cannot happen for
a relation with no replica identity.  However this is true only for a
change that needs references to old rows, aka UPDATE or DELETE, so
trying to use logical replication with a relation that has no replica
identity led to an assertion failure in the publisher when issuing an
INSERT.  This commit removes the incorrect assertion, and adds more
regression tests to provide coverage for relations without replica
identity.

Reported-by: Neha Sharma
Author: Dilip Kumar, Michael Paquier
Reviewed-by: Andres Freund
Discussion: https://postgr.es/m/CANiYTQsL1Hb8_Km08qd32svrqNumXLJeoGo014O7VZymgOhZEA@mail.gmail.com
Backpatch-through: 10
src/backend/replication/logical/proto.c
src/test/subscription/t/001_rep_changes.pl