]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
Remove all remaining text() coercions and ensure identifiers are safe
authorMike Bayer <mike_mp@zzzcomputing.com>
Mon, 4 Feb 2019 20:50:29 +0000 (15:50 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Thu, 7 Feb 2019 03:53:16 +0000 (22:53 -0500)
commit30307c4616ad67c01ddae2e1e8e34fabf6028414
tree6e8edd4cb13132aa19f916409f3a3f3dcba7fd0c
parent11845453d76e1576f637161e660160f0a6117af6
Remove all remaining text() coercions and ensure identifiers are safe

Fully removed the behavior of strings passed directly as components of a
:func:`.select` or :class:`.Query` object being coerced to :func:`.text`
constructs automatically; the warning that has been emitted is now an
ArgumentError or in the case of order_by() / group_by() a CompileError.
This has emitted a warning since version 1.0 however its presence continues
to create concerns for the potential of mis-use of this behavior.

Note that public CVEs have been posted for order_by() / group_by() which
are resolved by this commit:  CVE-2019-7164  CVE-2019-7548

Added "SQL phrase validation" to key DDL phrases that are accepted as plain
strings, including :paramref:`.ForeignKeyConstraint.on_delete`,
:paramref:`.ForeignKeyConstraint.on_update`,
:paramref:`.ExcludeConstraint.using`,
:paramref:`.ForeignKeyConstraint.initially`, for areas where a series of SQL
keywords only are expected.Any non-space characters that suggest the phrase
would need to be quoted will raise a :class:`.CompileError`.   This change
is related to the series of changes committed as part of :ticket:`4481`.

Fixed issue where using an uppercase name for an index type (e.g. GIST,
BTREE, etc. ) or an EXCLUDE constraint would treat it as an identifier to
be quoted, rather than rendering it as is. The new behavior converts these
types to lowercase and ensures they contain only valid SQL characters.

Quoting is applied to :class:`.Function` names, those which are usually but
not necessarily generated from the :attr:`.sql.func` construct,  at compile
time if they contain illegal characters, such as spaces or punctuation. The
names are as before treated as case insensitive however, meaning if the
names contain uppercase or mixed case characters, that alone does not
trigger quoting. The case insensitivity is currently maintained for
backwards compatibility.

Fixes: #4481
Fixes: #4473
Fixes: #4467
Change-Id: Ib22a27d62930e24702e2f0f7c74a0473385a08eb
26 files changed:
doc/build/changelog/migration_13.rst
doc/build/changelog/unreleased_13/4467.rst [new file with mode: 0644]
doc/build/changelog/unreleased_13/4473.rst [new file with mode: 0644]
doc/build/changelog/unreleased_13/4481.rst [new file with mode: 0644]
doc/build/changelog/unreleased_13/ddl_validation.rst [new file with mode: 0644]
lib/sqlalchemy/__init__.py
lib/sqlalchemy/dialects/postgresql/base.py
lib/sqlalchemy/dialects/postgresql/ext.py
lib/sqlalchemy/orm/session.py
lib/sqlalchemy/sql/compiler.py
lib/sqlalchemy/sql/elements.py
lib/sqlalchemy/sql/expression.py
lib/sqlalchemy/sql/schema.py
lib/sqlalchemy/sql/selectable.py
lib/sqlalchemy/util/__init__.py
lib/sqlalchemy/util/deprecations.py
lib/sqlalchemy/util/langhelpers.py
test/dialect/mysql/test_compiler.py
test/dialect/postgresql/test_compiler.py
test/orm/test_eager_relations.py
test/orm/test_query.py
test/sql/test_compiler.py
test/sql/test_defaults.py
test/sql/test_functions.py
test/sql/test_text.py
test/test_schema.db [new file with mode: 0644]