]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
pmdomain: mtk-pm-domains: Fix spinlock recursion fix in probe
authorMacpaul Lin <macpaul.lin@mediatek.com>
Fri, 28 Nov 2025 04:17:22 +0000 (12:17 +0800)
committerUlf Hansson <ulf.hansson@linaro.org>
Mon, 29 Dec 2025 10:41:09 +0000 (11:41 +0100)
commit305f254727bd379bbed0385afa0162f5bde1f51c
treee44a43c749a4782d7f1dc169657cec4dc43ce50d
parentf8f9c1f4d0c7a64600e2ca312dec824a0bc2f1da
pmdomain: mtk-pm-domains: Fix spinlock recursion fix in probe

Remove scpsys_get_legacy_regmap(), replacing its usage with
of_find_node_with_property(). Explicitly call of_node_get(np) before each
of_find_node_with_property() to maintain correct node reference counting.

The of_find_node_with_property() function "consumes" its input by calling
of_node_put() internally, whether or not it finds a match.  Currently,
dev->of_node (np) is passed multiple times in sequence without incrementing
its reference count, causing it to be decremented multiple times and
risking early memory release.

Adding of_node_get(np) before each call balances the reference count,
preventing premature node release.

Fixes: c1bac49fe91f ("pmdomains: mtk-pm-domains: Fix spinlock recursion in probe")
Cc: stable@vger.kernel.org
Signed-off-by: Macpaul Lin <macpaul.lin@mediatek.com>
Tested-by: Louis-Alexis Eyraud <louisalexis.eyraud@collabora.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
drivers/pmdomain/mediatek/mtk-pm-domains.c