]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix corner-case 64-bit integer subtraction bug on some platforms.
authorDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 9 Nov 2023 09:54:22 +0000 (09:54 +0000)
committerDean Rasheed <dean.a.rasheed@gmail.com>
Thu, 9 Nov 2023 09:54:22 +0000 (09:54 +0000)
commit308a69a9878212bc2f96279023ce16070dac9214
tree922f0c3e120a2a9f156ad756e4cf492ba0e21a36
parent0e28091d5507bd63d5ad51e9795dd368aa4c7c4c
Fix corner-case 64-bit integer subtraction bug on some platforms.

When computing "0 - INT64_MIN", most platforms would report an
overflow error, which is correct. However, platforms without integer
overflow builtins or 128-bit integers would fail to spot the overflow,
and incorrectly return INT64_MIN.

Back-patch to all supported branches.

Patch be me. Thanks to Jian He for initial investigation, and Laurenz
Albe and Tom Lane for review.

Discussion: https://postgr.es/m/CAEZATCUNK-AZSD0jVdgkk0N%3DNcAXBWeAEX-QU9AnJPensikmdQ%40mail.gmail.com
src/include/common/int.h
src/test/regress/expected/int8.out
src/test/regress/sql/int8.sql