]> git.ipfire.org Git - thirdparty/haproxy.git/commit
BUG/MINOR: proto_tcp: delete fd from fdtab if listen() fails
authorValentine Krasnobaeva <vkrasnobaeva@haproxy.com>
Wed, 7 Aug 2024 17:31:09 +0000 (19:31 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 8 Aug 2024 14:33:53 +0000 (16:33 +0200)
commit308c6881c03b6302afd5cc48781d73a11ef994d4
tree3d2db3918608f9c04b01dcc1e672207ff8d8d76d
parent8427c5b5421a93ee29170fb6ca3093478acd7ab7
BUG/MINOR: proto_tcp: delete fd from fdtab if listen() fails

If listen() fails, fd should be deleted from fdtab, not just closed. Otherwise,
sock_inet_bind_receiver(), which is called in loop for each receiver, will
obtain the same fd via socket() for the next receiver, registered in the
receivers list. Then, it will bind it again and it will try to re-insert it in
fdtab, and fd_insert() will trigger the BUG_ON(fdtab[fd].owner != NULL) check.

When tcp_bind_listener() code was implemented, the use of fd_delete() was
not generalized and this one remained overlooked.

This can be backported to all stable versions.
src/proto_tcp.c