]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: stmmac: delete the eee_ctrl_timer after napi disabled
authorFugang Duan <fugang.duan@nxp.com>
Mon, 7 Dec 2020 10:51:40 +0000 (18:51 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 30 Dec 2020 10:25:41 +0000 (11:25 +0100)
commit30b1b5aae6b2ffef8e0cf64fb0b555bb3e4a1026
treeaa8db223ddd6da340ab86a72700c4418913fb1e6
parentba88ac9e5832be764f25d233f51e064302717314
net: stmmac: delete the eee_ctrl_timer after napi disabled

[ Upstream commit 5f58591323bf3f342920179f24515935c4b5fd60 ]

There have chance to re-enable the eee_ctrl_timer and fire the timer
in napi callback after delete the timer in .stmmac_release(), which
introduces to access eee registers in the timer function after clocks
are disabled then causes system hang. Found this issue when do
suspend/resume and reboot stress test.

It is safe to delete the timer after napi disabled and disable lpi mode.

Fixes: d765955d2ae0b ("stmmac: add the Energy Efficient Ethernet support")
Signed-off-by: Fugang Duan <fugang.duan@nxp.com>
Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/stmicro/stmmac/stmmac_main.c