]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
nvme-multipath: system fails to create generic nvme device
authorHannes Reinecke <hare@kernel.org>
Sat, 14 Sep 2024 12:01:22 +0000 (14:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 4 Oct 2024 14:29:38 +0000 (16:29 +0200)
commit30b9bf4b4107ce45316a41cfda2589f70e6a7f9b
tree4072e460b99867e925286cd894d4414c8e60d9cf
parentecb8a79d21fb9c39c7aceb464ab7c21e31e70729
nvme-multipath: system fails to create generic nvme device

[ Upstream commit 63bcf9014e95a7d279d10d8e2caa5d88db2b1855 ]

NVME_NSHEAD_DISK_LIVE is a flag for struct nvme_ns_head, not nvme_ns.
The current code has a typo causing NVME_NSHEAD_DISK_LIVE never to
be cleared once device_add_disk_fails, causing the system never to
create the 'generic' character device. Even several rescan attempts
will change the situation and the system has to be rebooted to fix
the issue.

Fixes: 11384580e332 ("nvme-multipath: add error handling support for add_disk()")
Signed-off-by: Hannes Reinecke <hare@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/nvme/host/multipath.c