]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "drm/sun4i: drv: Allow framebuffer modifiers in mode config"
authorJernej Skrabec <jernej.skrabec@siol.net>
Sun, 26 Jan 2020 06:59:37 +0000 (07:59 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 19 Feb 2020 18:54:12 +0000 (19:54 +0100)
commit30bb9bda34156b1105f216af10ada9dd89f1310f
treefb250a7244c1fea76809c6ca6fab1c7ef9e7773d
parent3832448c6663dd7147184448f5b6cbe524121223
Revert "drm/sun4i: drv: Allow framebuffer modifiers in mode config"

commit cf913e9683273f2640501094fa63a67e29f437b3 upstream.

This reverts commit 9db9c0cf5895e4ddde2814360cae7bea9282edd2.

Setting mode_config.allow_fb_modifiers manually is completely
unnecessary. It is set automatically by drm_universal_plane_init() based
on the fact if modifier list is provided or not. Even more, it breaks
DE2 and DE3 as they don't support any modifiers beside linear. Modifiers
aware applications can be confused by provided empty modifier list - at
least linear modifier should be included, but it's not for DE2 and DE3.

Fixes: 9db9c0cf5895 ("drm/sun4i: drv: Allow framebuffer modifiers in mode config")
Signed-off-by: Jernej Skrabec <jernej.skrabec@siol.net>
Reviewed-by: Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Signed-off-by: Maxime Ripard <maxime@cerno.tech>
Link: https://patchwork.freedesktop.org/patch/msgid/20200126065937.9564-1-jernej.skrabec@siol.net
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/sun4i/sun4i_drv.c