]> git.ipfire.org Git - thirdparty/asterisk.git/commit
various files - fix some alerts raised by lgtm code analysis
authorKevin Harwell <kharwell@digium.com>
Wed, 23 Oct 2019 17:36:17 +0000 (12:36 -0500)
committerGeorge Joseph <gjoseph@digium.com>
Mon, 18 Nov 2019 14:30:05 +0000 (08:30 -0600)
commit30c0af7257eb11a69efbd4edfe1a45ec27759e1e
treeb5d7294b6c1ffc64665734fd8ede40b1dc80ce93
parente7320bbbf002595e3244daa3dad3868bfdd30992
various files - fix some alerts raised by lgtm code analysis

This patch fixes several issues reported by the lgtm code analysis tool:

https://lgtm.com/projects/g/asterisk/asterisk

Not all reported issues were addressed in this patch. This patch mostly fixes
confirmed reported errors, potential problematic code points, and a few other
"low hanging" warnings or recommendations found in core supported modules.
These include, but are not limited to the following:

* innapropriate stack allocation in loops
* buffer overflows
* variable declaration "hiding" another variable declaration
* comparisons results that are always the same
* ambiguously signed bit-field members
* missing header guards

Change-Id: Id4a881686605d26c94ab5409bc70fcc21efacc25
49 files changed:
apps/app_cdr.c
apps/app_dictate.c
apps/app_followme.c
apps/app_minivm.c
apps/app_playback.c
apps/app_readexten.c
apps/app_voicemail.c
channels/chan_dahdi.c
channels/chan_dahdi.h
channels/chan_motif.c
codecs/ex_alaw.h
codecs/ex_g722.h
codecs/ex_ulaw.h
formats/format_g726.c
formats/msgsm.h
include/asterisk/ari.h
include/asterisk/calendar.h
include/asterisk/channel_internal.h
include/asterisk/config_options.h
include/asterisk/dns_internal.h
include/asterisk/max_forwards.h
include/asterisk/mixmonitor.h
include/asterisk/parking.h
include/asterisk/res_pjsip_presence_xml.h
include/asterisk/slin.h
main/app.c
main/asterisk.c
main/event.c
main/file.c
main/indications.c
main/manager.c
main/pbx_variables.c
main/stasis.c
main/stasis_cache.c
res/ari/config.c
res/parking/parking_bridge_features.c
res/parking/res_parking.h
res/res_config_curl.c
res/res_phoneprov.c
res/res_pjsip/config_system.c
res/res_pjsip/config_transport.c
res/res_pjsip/pjsip_resolver.c
res/res_pjsip_endpoint_identifier_ip.c
res/res_pjsip_registrar.c
res/res_pjsip_t38.c
res/res_resolver_unbound.c
res/res_rtp_asterisk.c
res/stasis/command.c
res/stasis/control.c