]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
SUNRPC: Ensure we return EAGAIN in xs_nospace if congestion is cleared
authorTrond Myklebust <Trond.Myklebust@netapp.com>
Tue, 22 Nov 2011 12:44:28 +0000 (14:44 +0200)
committerPaul Gortmaker <paul.gortmaker@windriver.com>
Wed, 16 Jan 2013 21:44:58 +0000 (16:44 -0500)
commit30c42309ea65847d822101fe4fa4d0bce177769e
treee9dc07c0183fa9d9fa76ab153ceba3d8f797c8a3
parent84248cd08252b61e76a26a0d83a9596a29e4e564
SUNRPC: Ensure we return EAGAIN in xs_nospace if congestion is cleared

commit 24ca9a847791fd53d9b217330b15f3c285827a18 upstream.

By returning '0' instead of 'EAGAIN' when the tests in xs_nospace() fail
to find evidence of socket congestion, we are making the RPC engine believe
that the message was incorrectly sent and so it disconnects the socket
instead of just retrying.

The bug appears to have been introduced by commit
5e3771ce2d6a69e10fcc870cdf226d121d868491 (SUNRPC: Ensure that xs_nospace
return values are propagated).

Reported-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Trond Myklebust <Trond.Myklebust@netapp.com>
Tested-by: Andrew Cooper <andrew.cooper3@citrix.com>
Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
net/sunrpc/xprtsock.c