]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
can: sja1000: fix max irq loop handling
authorThomas Mühlbacher <tmuehlbacher@posteo.net>
Sat, 15 Nov 2025 15:34:56 +0000 (15:34 +0000)
committerMarc Kleine-Budde <mkl@pengutronix.de>
Sun, 16 Nov 2025 15:34:41 +0000 (16:34 +0100)
commit30db4451c7f6aabcada029b15859a76962ec0cf8
tree999a9aafa5d10975dee30aa6995fefd96e533cc7
parent0c73772cd2b8cc108d5f5334de89ad648d89b9ec
can: sja1000: fix max irq loop handling

Reading the interrupt register `SJA1000_IR` causes all of its bits to be
reset. If we ever reach the condition of handling more than
`SJA1000_MAX_IRQ` IRQs, we will have read the register and reset all its
bits but without actually handling the interrupt inside of the loop
body.

This may, among other issues, cause us to never `netif_wake_queue()`
again after a transmission interrupt.

Fixes: 429da1cc841b ("can: Driver for the SJA1000 CAN controller")
Cc: stable@vger.kernel.org
Signed-off-by: Thomas Mühlbacher <tmuehlbacher@posteo.net>
Acked-by: Oliver Hartkopp <socketcan@hartkopp.net>
Link: https://patch.msgid.link/20251115153437.11419-1-tmuehlbacher@posteo.net
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
drivers/net/can/sja1000/sja1000.c