]> git.ipfire.org Git - thirdparty/libvirt.git/commit
conf: fix virDevicePCIAddressEqual args
authorLaine Stump <laine@laine.org>
Thu, 11 Oct 2012 16:34:14 +0000 (12:34 -0400)
committerLaine Stump <laine@laine.org>
Mon, 15 Oct 2012 08:03:06 +0000 (04:03 -0400)
commit310945597c9db7f4f9b4e251e4fda7f75f6bc0e2
tree03cad03abeac2ab3f10ae6ddb305bb237fa1396f
parenta2b80edbc69c8039ff73ac38ee2cf32875b68083
conf: fix virDevicePCIAddressEqual args

This function really should have been taking virDevicePCIAddress*
instead of the inefficient virDevicePCIAddress (results in copying two
entire structs onto the stack rather than just two pointers), and
returning a bool true/false (not matching is not necessarily a
"failure", as a -1 return would imply, and also using "if
(!virDevicePCIAddressEqual(x, y))" to mean "if x == y" is just a bit
counterintuitive).
src/conf/device_conf.c
src/conf/device_conf.h
src/network/bridge_driver.c