]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ALSA: ump: Don't clear bank selection after sending a program change
authorTakashi Iwai <tiwai@suse.de>
Wed, 29 May 2024 08:38:21 +0000 (10:38 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 16 Jun 2024 11:47:46 +0000 (13:47 +0200)
commit3113ff8e496ce0fc0ffa6bb17c5d227f79ccc3ac
treedc22762f67f070050eb1527ef875a0fd6ba70547
parente3ae00ee238bce6cfa5ad935c921181c14d18fd6
ALSA: ump: Don't clear bank selection after sending a program change

commit fe85f6e607d75b856e7229924c71f55e005f8284 upstream.

The current code clears the bank selection MSB/LSB after sending a
program change, but this can be wrong, as many apps may not send the
full bank selection with both MSB and LSB but sending only one.
Better to keep the previous bank set.

Fixes: 0b5288f5fe63 ("ALSA: ump: Add legacy raw MIDI support")
Cc: <stable@vger.kernel.org>
Link: https://lore.kernel.org/r/20240529083823.5778-1-tiwai@suse.de
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
sound/core/ump_convert.c