]> git.ipfire.org Git - thirdparty/Python/cpython.git/commit
(Merge 3.4) asyncio, tulip issue 196: ProactorIocp._register() now registers
authorVictor Stinner <victor.stinner@gmail.com>
Sun, 27 Jul 2014 22:19:36 +0000 (00:19 +0200)
committerVictor Stinner <victor.stinner@gmail.com>
Sun, 27 Jul 2014 22:19:36 +0000 (00:19 +0200)
commit314397aeef7ae284c98137dacb011985614b135e
treedfe90623a74780b87b03abd1c4b6a889863f11c7
parent0f41acb0eab3314aa9235632de9f0c705a51a6f1
parent42d3bdeed6e34117b787d61a471563a0dba6a894
(Merge 3.4) asyncio, tulip issue 196: ProactorIocp._register() now registers
the overlapped in the _cache dictionary, even if we already got the result. We
need to keep a reference to the overlapped object, otherwise the memory may be
reused and GetQueuedCompletionStatus() may use random bytes and behaves badly.

There is still a hack for ConnectNamedPipe(): the overlapped object is not
register into _cache if the overlapped object completed directly.

Log also an error in debug mode in ProactorIocp._loop() if we get an unexpected
event.

Add a protection in ProactorIocp.close() to avoid blocking, even if it should
not happen. I still don't understand exactly why some the completion of some
overlapped objects are not notified.