]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/amd/display: Initialise backlight level values from hw
authorVivek Das Mohapatra <vivek@collabora.com>
Mon, 12 Jan 2026 15:28:56 +0000 (15:28 +0000)
committerAlex Deucher <alexander.deucher@amd.com>
Wed, 14 Jan 2026 19:28:48 +0000 (14:28 -0500)
commit318b1c36d82a0cd2b06a4bb43272fa6f1bc8adc1
tree1ccbb139bb53e33c003f79276959118990a82175
parentfff90bb3d4e56586e06d405b683af67d6271023b
drm/amd/display: Initialise backlight level values from hw

Internal backlight levels are initialised from ACPI but the values
are sometimes out of sync with the levels in effect until there has
been a read from hardware (eg triggered by reading from sysfs).

This means that the first drm_commit can cause the levels to be set
to a different value than the actual starting one, which results in
a sudden change in brightness.

This path shows the problem (when the values are out of sync):

   amdgpu_dm_atomic_commit_tail()
   -> amdgpu_dm_commit_streams()
   -> amdgpu_dm_backlight_set_level(..., dm->brightness[n])

This patch calls the backlight ops get_brightness explicitly
at the end of backlight registration to make sure dm->brightness[n]
is in sync with the actual hardware levels.

Fixes: 2fe87f54abdc ("drm/amd/display: Set default brightness according to ACPI")
Signed-off-by: Vivek Das Mohapatra <vivek@collabora.com>
Reviewed-by: Mario Limonciello (AMD) <superm1@kernel.org>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c