]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
bpf: Check sk_state before sk_protocol in bpf_tcp_*_syncookie
authorLuxiao Xu <rakukuip@gmail.com>
Tue, 4 Aug 2026 14:29:01 +0000 (22:29 +0800)
committerDaniel Borkmann <daniel@iogearbox.net>
Wed, 5 Aug 2026 20:24:27 +0000 (22:24 +0200)
commit31a420a822ff92e2090bd5d65efe8e34e2d6d9b8
tree4bef6ad94c127169006fee265d485e334c735f1f
parent7cd8645d2b23e396228c78d83ef80a210154a1d9
bpf: Check sk_state before sk_protocol in bpf_tcp_*_syncookie

bpf_tcp_gen_syncookie and bpf_tcp_check_syncookie accept a socket pointer
'sk' with argument type ARG_PTR_TO_BTF_ID_SOCK_COMMON. However, they access
sk->sk_protocol without validating whether 'sk' represents a full socket.

Fix this issue by checking sk->sk_state != TCP_LISTEN before inspecting
sk->sk_protocol in both bpf_tcp_gen_syncookie and bpf_tcp_check_syncookie.
Since mini-sockets are never in the TCP_LISTEN state, the condition
short-circuits and prevents dereferencing fullsock-specific fields.

Fixes: 399040847084 ("bpf: add helper to check for a valid SYN cookie")
Fixes: 70d66244317e ("bpf: add bpf_tcp_gen_syncookie helper")
Reported-by: Vega <vega@nebusec.ai>
Signed-off-by: Luxiao Xu <rakukuip@gmail.com>
Signed-off-by: Ren Wei <enjou1224z@gmail.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://lore.kernel.org/bpf/6218aa3534d0d2d3f448fde70a8dc2769d7a8201.1785823138.git.rakukuip@gmail.com
net/core/filter.c