]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
watchdog: rzg2l_wdt: Fix reset control imbalance
authorBiju Das <biju.das.jz@bp.renesas.com>
Fri, 25 Feb 2022 17:53:17 +0000 (17:53 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 14 Jun 2022 16:41:17 +0000 (18:41 +0200)
commit31db539abd4c5ec992a06cf39512688bc044b490
treeb3395c9f6457e108f21f5c102137d0ca273c299e
parent6505541e5298cea2b79da68ee626f583f8e18784
watchdog: rzg2l_wdt: Fix reset control imbalance

[ Upstream commit 33d04d0fdba9fae18c7d58364643d2c606a43dba ]

Both rzg2l_wdt_probe() and rzg2l_wdt_start() calls reset_control_
deassert() which results in a reset control imbalance.

This patch fixes reset control imbalance by removing reset_control_
deassert() from rzg2l_wdt_start() and replaces reset_control_assert with
reset_control_reset in rzg2l_wdt_stop() as watchdog module can be stopped
only by a module reset. This change will allow us to restart WDT after
stop() by configuring WDT timeout and enable registers.

Fixes: 2cbc5cd0b55fa2 ("watchdog: Add Watchdog Timer driver for RZ/G2L")
Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20220225175320.11041-5-biju.das.jz@bp.renesas.com
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/watchdog/rzg2l_wdt.c