]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tipc: fix a possible memleak in tipc_buf_append
authorXin Long <lucien.xin@gmail.com>
Tue, 30 Apr 2024 14:03:38 +0000 (10:03 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 17 May 2024 10:14:33 +0000 (12:14 +0200)
commit3210d34fda4caff212cb53729e6bd46de604d565
tree2c281c651f93a78da58f4e855ff921acc8b13b29
parent7a94a411f1102cefcc6fc8a814b58cd51cce77b7
tipc: fix a possible memleak in tipc_buf_append

[ Upstream commit 97bf6f81b29a8efaf5d0983251a7450e5794370d ]

__skb_linearize() doesn't free the skb when it fails, so move
'*buf = NULL' after __skb_linearize(), so that the skb can be
freed on the err path.

Fixes: b7df21cf1b79 ("tipc: skb_linearize the head skb when reassembling msgs")
Reported-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Xin Long <lucien.xin@gmail.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Reviewed-by: Tung Nguyen <tung.q.nguyen@dektech.com.au>
Link: https://lore.kernel.org/r/90710748c29a1521efac4f75ea01b3b7e61414cf.1714485818.git.lucien.xin@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
net/tipc/msg.c