]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
soc: amlogic: canvas: fix device leak on lookup
authorJohan Hovold <johan@kernel.org>
Fri, 26 Sep 2025 14:24:53 +0000 (16:24 +0200)
committerNeil Armstrong <neil.armstrong@linaro.org>
Tue, 21 Oct 2025 12:20:29 +0000 (14:20 +0200)
commit32200f4828de9d7e6db379909898e718747f4e18
treea06f8f1485ff77a549dbd3e596f7ac7a1709ab40
parent3a8660878839faadb4f1a6dd72c3179c1df56787
soc: amlogic: canvas: fix device leak on lookup

Make sure to drop the reference taken to the canvas platform device when
looking up its driver data.

Note that holding a reference to a device does not prevent its driver
data from going away so there is no point in keeping the reference.

Also note that commit 28f851e6afa8 ("soc: amlogic: canvas: add missing
put_device() call in meson_canvas_get()") fixed the leak in a lookup
error path, but the reference is still leaking on success.

Fixes: d4983983d987 ("soc: amlogic: add meson-canvas driver")
Cc: stable@vger.kernel.org # 4.20: 28f851e6afa8
Cc: Yu Kuai <yukuai3@huawei.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Link: https://patch.msgid.link/20250926142454.5929-2-johan@kernel.org
Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
drivers/soc/amlogic/meson-canvas.c