]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
net: marvell: prestera: correct return type of prestera_ldr_wait_buf()
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Sat, 3 Jan 2026 17:43:10 +0000 (09:43 -0800)
committerJakub Kicinski <kuba@kernel.org>
Tue, 6 Jan 2026 00:18:03 +0000 (16:18 -0800)
commit32291cb0369aa56946b3a0768a7d54f9490a83ce
tree1866e727cad33fbae6937be2bd9dbf6871d3c5b8
parent2e229771543b2b20e1fe29da00df80c917469449
net: marvell: prestera: correct return type of prestera_ldr_wait_buf()

prestera_ldr_wait_buf() returns the result of readl_poll_timeout(),
which is 0 on success or -ETIMEDOUT on failure. Its current return
type is u32.

Assigning this u32 value to an int variable works today because the
bit pattern of (u32)-ETIMEDOUT (0xffffff92) is correctly interpreted
as -ETIMEDOUT when stored in an int. However, keeping the function
return type as u32 is misleading and fragile.

Change the return type to int to reflect the actual semantic of
returning negative error codes and to avoid potential issues with
unsigned casts. There is no functional change.

Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://patch.msgid.link/20260103174313.1172197-1-alok.a.tiwari@oracle.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/marvell/prestera/prestera_pci.c