]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commit
adjust MySQL view reflection for non-standard MySQL variants
authorJohn Bodley <4567245+john-bodley@users.noreply.github.com>
Fri, 30 Sep 2022 01:58:58 +0000 (21:58 -0400)
committerMike Bayer <mike_mp@zzzcomputing.com>
Tue, 4 Oct 2022 02:45:49 +0000 (22:45 -0400)
commit322b9b4faa6dfd4eea3d2ba12825850318a59ef4
tree002fe6d9246947d8b590044bcb73b91aad32aedf
parentf35446512582defc2fcde826b8c059ed09ddabf3
adjust MySQL view reflection for non-standard MySQL variants

Adjusted the regular expression used to match "CREATE VIEW" when
testing for views to work more flexibly, no longer requiring the
special keyword "ALGORITHM" in the middle, which was intended to be
optional but was not working correctly.  The change allows view reflection
to work more completely on MySQL-compatible variants such as StarRocks.
Pull request courtesy John Bodley.

Fixes: #8588
Closes: #8589
Pull-request: https://github.com/sqlalchemy/sqlalchemy/pull/8589
Pull-request-sha: d85b2c5b51e45cec543c9ae9d62d6d659b063354

Change-Id: I173137f0bf68639cad0d5c329055475b40ddb5e4
(cherry picked from commit 9829bc43d69ea5e714014f5ac5f036a94d13bc08)
doc/build/changelog/unreleased_14/8588.rst [new file with mode: 0644]
lib/sqlalchemy/dialects/mysql/base.py
lib/sqlalchemy/dialects/mysql/reflection.py
test/dialect/mysql/test_reflection.py