]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Bluetooth: btrtl: Prevent potential NULL dereference
authorDan Carpenter <dan.carpenter@linaro.org>
Wed, 2 Apr 2025 11:01:41 +0000 (14:01 +0300)
committerLuiz Augusto von Dentz <luiz.von.dentz@intel.com>
Thu, 10 Apr 2025 17:09:16 +0000 (13:09 -0400)
commit324dddea321078a6eeb535c2bff5257be74c9799
treebea03ec25713c16a3929c292b508c7afaeaa541f
parenteb73b5a9157221f405b4fe32751da84ee46b7a25
Bluetooth: btrtl: Prevent potential NULL dereference

The btrtl_initialize() function checks that rtl_load_file() either
had an error or it loaded a zero length file.  However, if it loaded
a zero length file then the error code is not set correctly.  It
results in an error pointer vs NULL bug, followed by a NULL pointer
dereference.  This was detected by Smatch:

drivers/bluetooth/btrtl.c:592 btrtl_initialize() warn: passing zero to 'ERR_PTR'

Fixes: 26503ad25de8 ("Bluetooth: btrtl: split the device initialization into smaller parts")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
drivers/bluetooth/btrtl.c