]> git.ipfire.org Git - thirdparty/git.git/commit
xdiff: avoid using the comma operator unnecessarily
authorJohannes Schindelin <johannes.schindelin@gmx.de>
Thu, 27 Mar 2025 11:52:58 +0000 (11:52 +0000)
committerJunio C Hamano <gitster@pobox.com>
Sat, 29 Mar 2025 00:38:10 +0000 (17:38 -0700)
commit324fbaab88126196bd42e7fa383ee94e165d61b5
tree780dd9064ddc50c7fed47bd888dd2012201de3ee
parent0fbbb2c9f595a8460a7fd7c72d4e95081eb96b08
xdiff: avoid using the comma operator unnecessarily

The comma operator is a somewhat obscure C feature that is often used by
mistake and can even cause unintentional code flow. While the code in
this patch used the comma operator intentionally (to avoid curly
brackets around two statements, each, that want to be guarded by a
condition), it is better to surround it with curly brackets and to use a
semicolon instead.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Acked-by: Phillip Wood <phillip.wood@dunelm.org.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
xdiff/xdiffi.c