]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ext4: wait for ongoing I/O to complete before freeing blocks
authorZhang Yi <yi.zhang@huawei.com>
Tue, 16 Sep 2025 09:33:37 +0000 (17:33 +0800)
committerTheodore Ts'o <tytso@mit.edu>
Fri, 10 Oct 2025 17:34:35 +0000 (13:34 -0400)
commit328a782cb138029182e521c08f50eb1587db955d
tree7b9c90276b63fb8329bbacfefa953ca764d186a5
parent3c652c3a71de1d30d72dc82c3bead8deb48eb749
ext4: wait for ongoing I/O to complete before freeing blocks

When freeing metadata blocks in nojournal mode, ext4_forget() calls
bforget() to clear the dirty flag on the buffer_head and remvoe
associated mappings. This is acceptable if the metadata has not yet
begun to be written back. However, if the write-back has already started
but is not yet completed, ext4_forget() will have no effect.
Subsequently, ext4_mb_clear_bb() will immediately return the block to
the mb allocator. This block can then be reallocated immediately,
potentially causing an data corruption issue.

Fix this by clearing the buffer's dirty flag and waiting for the ongoing
I/O to complete, ensuring that no further writes to stale data will
occur.

Fixes: 16e08b14a455 ("ext4: cleanup clean_bdev_aliases() calls")
Cc: stable@kernel.org
Reported-by: Gao Xiang <hsiangkao@linux.alibaba.com>
Closes: https://lore.kernel.org/linux-ext4/a9417096-9549-4441-9878-b1955b899b4e@huaweicloud.com/
Signed-off-by: Zhang Yi <yi.zhang@huawei.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Message-ID: <20250916093337.3161016-3-yi.zhang@huaweicloud.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
fs/ext4/ext4_jbd2.c