]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
mips: Add __attribute_const__ to ffs()-family implementations
authorKees Cook <kees@kernel.org>
Mon, 4 Aug 2025 16:44:08 +0000 (09:44 -0700)
committerKees Cook <kees@kernel.org>
Mon, 8 Sep 2025 21:58:51 +0000 (14:58 -0700)
commit32913fe7f71e72fb49033df35ec6388ff7b170ff
tree3c9e7bfab561bcda27a744c6a99a1d321822ac3a
parent50c869a6cecabb522f157fa6cc41bca2eb8aecb4
mips: Add __attribute_const__ to ffs()-family implementations

While tracking down a problem where constant expressions used by
BUILD_BUG_ON() suddenly stopped working[1], we found that an added static
initializer was convincing the compiler that it couldn't track the state
of the prior statically initialized value. Tracing this down found that
ffs() was used in the initializer macro, but since it wasn't marked with
__attribute__const__, the compiler had to assume the function might
change variable states as a side-effect (which is not true for ffs(),
which provides deterministic math results).

Add missing __attribute_const__ annotations to MIPS's implementations of
ffs(), __ffs(), fls(), and __fls() functions. These are pure mathematical
functions that always return the same result for the same input with no
side effects, making them eligible for compiler optimization.

Build tested ARCH=mips defconfig with GCC mipsel-linux-gnu 14.2.0.

Link: https://github.com/KSPP/linux/issues/364
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Link: https://lore.kernel.org/r/20250804164417.1612371-12-kees@kernel.org
Signed-off-by: Kees Cook <kees@kernel.org>
arch/mips/include/asm/bitops.h