]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
Revert "serial: 8250: Don't service RX FIFO if interrupts are disabled"
authorOliver Barta <o.barta89@gmail.com>
Wed, 19 Jun 2019 08:16:39 +0000 (10:16 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 14 Jul 2019 06:09:49 +0000 (08:09 +0200)
commit32a88e920591efb9beff6a1916ca05dc98b9bb2e
tree12a0f8d523a3020ce67ed7cf1e4d0cb382e4530f
parentc02af52b6c1c55bd930f7988059cfbfc2d790be6
Revert "serial: 8250: Don't service RX FIFO if interrupts are disabled"

commit 3f2640ed7be838c3f05c0d2b0f7c7508e7431e48 upstream.

This reverts commit 2e9fe539108320820016f78ca7704a7342788380.

Reading LSR unconditionally but processing the error flags only if
UART_IIR_RDI bit was set before in IIR may lead to a loss of transmission
error information on UARTs where the transmission error flags are cleared
by a read of LSR. Information are lost in case an error is detected right
before the read of LSR while processing e.g. an UART_IIR_THRI interrupt.

Signed-off-by: Oliver Barta <o.barta89@gmail.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Fixes: 2e9fe5391083 ("serial: 8250: Don't service RX FIFO if interrupts are disabled")
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/8250/8250_port.c