]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't use_physical_tlist for an IOS with non-returnable columns.
authorTom Lane <tgl@sss.pgh.pa.us>
Fri, 11 Feb 2022 20:23:52 +0000 (15:23 -0500)
committerTom Lane <tgl@sss.pgh.pa.us>
Fri, 11 Feb 2022 20:23:52 +0000 (15:23 -0500)
commit32e801676b1ef821c6ee308f7ea42386a3e15768
treea710c2a91afa063b3ea03707026461df09174344
parent61c20a5eaac3a77ff52a3a47ceb64ff238192281
Don't use_physical_tlist for an IOS with non-returnable columns.

createplan.c tries to save a runtime projection step by specifying
a scan plan node's output as being exactly the table's columns, or
index's columns in the case of an index-only scan, if there is not a
reason to do otherwise.  This logic did not previously pay attention
to whether an index's columns are returnable.  That worked, sort of
accidentally, until commit 9a3ddeb51 taught setrefs.c to reject plans
that try to read a non-returnable column.  I have no desire to loosen
setrefs.c's new check, so instead adjust use_physical_tlist() to not
try to optimize this way when there are non-returnable column(s).

Per report from Ryan Kelly.  Like the previous patch, back-patch
to all supported branches.

Discussion: https://postgr.es/m/CAHUie24ddN+pDNw7fkhNrjrwAX=fXXfGZZEHhRuofV_N_ftaSg@mail.gmail.com
src/backend/optimizer/plan/createplan.c
src/test/regress/expected/gist.out
src/test/regress/sql/gist.sql