]> git.ipfire.org Git - thirdparty/linux.git/commit
ALSA: core/seq: Optimize the return logic in cc_ev_to_ump_midi2
authorsongxiebing <songxiebing@kylinos.cn>
Wed, 25 Mar 2026 01:51:19 +0000 (09:51 +0800)
committerTakashi Iwai <tiwai@suse.de>
Fri, 27 Mar 2026 13:40:24 +0000 (14:40 +0100)
commit32f35f9d8e457f5b2ee1df3f7a45af42965bedfe
treedb1b7b2d6ca8bfa5dabcf75a41938ba800e69005
parent1e512ac1254c8e370dd18efe9da4dfc92492cdc5
ALSA: core/seq: Optimize the return logic in cc_ev_to_ump_midi2

There are multiple early return branches within the func, and compiler
optimizations(such as -O2/-O3)lead to abnormal stack frame analysis -
objtool cannot comfirm that the stack frames of all branches can be
correctly restored, thus generating false warnings.

Below:
>> sound/core/seq/seq_ump_convert.o: warning: objtool: cc_ev_to_ump_midi2+0x589: return with modified stack frame

So we modify it by uniformly returning at the and of the function.

Signed-off-by: songxiebing <songxiebing@kylinos.cn>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202503200535.J3hAvcjw-lkp@intel.com/
Link: https://patch.msgid.link/20260325015119.175835-1-songxiebing@kylinos.cn
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/core/seq/seq_ump_convert.c