]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_stat_statements: Fix crash in list squashing with Vars
authorMichael Paquier <michael@paquier.xyz>
Mon, 19 Jan 2026 23:11:16 +0000 (08:11 +0900)
committerMichael Paquier <michael@paquier.xyz>
Mon, 19 Jan 2026 23:11:16 +0000 (08:11 +0900)
commit3304e97b1b73e0ca7b14bbd8ed17162b3cb056ec
treee3b9cb532179c124a0f933816f127d9337d431e8
parentc80b0c9d63b25a1e7fc751a4cf66a6510ffafbb8
pg_stat_statements: Fix crash in list squashing with Vars

When IN/ANY clauses contain both constants and variable expressions, the
optimizer transforms them into separate structures: constants become
an array expression while variables become individual OR conditions.

This transformation was creating an overlap with the token locations,
causing pg_stat_statements query normalization to crash because it
could not calculate the amount of bytes remaining to write for the
normalized query.

This commit disables squashing for mixed IN list expressions when
constructing a scalar array op, by setting list_start and list_end
to -1 when both variables and non-variables are present.  Some
regression tests are added to PGSS to verify these patterns.

Author: Sami Imseih <samimseih@gmail.com>
Reviewed-by: Dmitry Dolgov <9erthalion6@gmail.com>
Discussion: https://postgr.es/m/CAA5RZ0ts9qiONnHjjHxPxtePs22GBo4d3jZ_s2BQC59AN7XbAA@mail.gmail.com
Backpatch-through: 18
contrib/pg_stat_statements/expected/squashing.out
contrib/pg_stat_statements/sql/squashing.sql
src/backend/parser/parse_expr.c