]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
kgdb: Remove "weak" from kgdb_arch_pc() declaration
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 14 Oct 2014 01:00:25 +0000 (19:00 -0600)
committerJiri Slaby <jslaby@suse.cz>
Wed, 19 Nov 2014 17:38:24 +0000 (18:38 +0100)
commit33176fe6d29e0a689928532db6cf44de67c72921
tree31bc1c63a4321cef7251237b4011f3fafcd9270e
parentc9813eda171c8e01f62f71623aff4b0fbe79106c
kgdb: Remove "weak" from kgdb_arch_pc() declaration

commit 107bcc6d566cb40184068d888637f9aefe6252dd upstream.

kernel/debug/debug_core.c provides a default kgdb_arch_pc() definition
explicitly marked "weak".  Several architectures provide their own
definitions intended to override the default, but the "weak" attribute on
the declaration applied to the arch definitions as well, so the linker
chose one based on link order (see 10629d711ed7 ("PCI: Remove __weak
annotation from pcibios_get_phb_of_node decl")).

Remove the "weak" attribute from the declaration so we always prefer a
non-weak definition over the weak one, independent of link order.

Fixes: 688b744d8bc8 ("kgdb: fix signedness mixmatches, add statics, add declaration to header")
Tested-by: Vineet Gupta <vgupta@synopsys.com> # for ARC build
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Harvey Harrison <harvey.harrison@gmail.com>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
include/linux/kgdb.h