]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
regulator: of: Implement the unwind path of of_regulator_match()
authorJoe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Sat, 4 Jan 2025 08:04:53 +0000 (17:04 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 13 Mar 2025 11:49:57 +0000 (12:49 +0100)
commit332ee5fc52e1b9654788bf409f4f8d709601a867
tree661f261c47b2cb5aa68b1e4979867d96c576c202
parentbd099a2fa9be983ba0e90a57a59484fe9d520ba8
regulator: of: Implement the unwind path of of_regulator_match()

[ Upstream commit dddca3b2fc676113c58b04aaefe84bfb958ac83e ]

of_regulator_match() does not release the OF node reference in the error
path, resulting in an OF node leak. Therefore, call of_node_put() on the
obtained nodes before returning the EINVAL error.

Since it is possible that some drivers call this function and do not
exit on failure, such as s2mps11_pmic_driver, clear the init_data and
of_node in the error path.

This was reported by an experimental verification tool that I am
developing. As I do not have access to actual devices nor the QEMU board
configuration to test drivers that call this function, no runtime test
was able to be performed.

Fixes: 1c8fa58f4750 ("regulator: Add generic DT parsing for regulators")
Signed-off-by: Joe Hattori <joe@pf.is.s.u-tokyo.ac.jp>
Link: https://patch.msgid.link/20250104080453.2153592-1-joe@pf.is.s.u-tokyo.ac.jp
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/regulator/of_regulator.c