]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform/mellanox: mlxreg-lc: Fix logic error in power state check
authorAlok Tiwari <alok.a.tiwari@oracle.com>
Mon, 30 Jun 2025 10:58:08 +0000 (03:58 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2025 14:03:10 +0000 (16:03 +0200)
commit33713f7cda3d541d7eee43b18e712acfa75cdf60
tree51188feef692d3dd29ae93a5d1864c8ee5f250b1
parent421672fb7f1339895900728ddd79a6459a309427
platform/mellanox: mlxreg-lc: Fix logic error in power state check

[ Upstream commit 644bec18e705ca41d444053407419a21832fcb2f ]

Fixes a logic issue in mlxreg_lc_completion_notify() where the
intention was to check if MLXREG_LC_POWERED flag is not set before
powering on the device.

The original code used "state & ~MLXREG_LC_POWERED" to check for the
absence of the POWERED bit. However this condition evaluates to true
even when other bits are set, leading to potentially incorrect
behavior.

Corrected the logic to explicitly check for the absence of
MLXREG_LC_POWERED using !(state & MLXREG_LC_POWERED).

Fixes: 62f9529b8d5c ("platform/mellanox: mlxreg-lc: Add initial support for Nvidia line card devices")
Suggested-by: Vadim Pasternak <vadimp@nvidia.com>
Signed-off-by: Alok Tiwari <alok.a.tiwari@oracle.com>
Link: https://lore.kernel.org/r/20250630105812.601014-1-alok.a.tiwari@oracle.com
Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/platform/mellanox/mlxreg-lc.c