]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
KEYS: Don't permit request_key() to construct a new keyring
authorDavid Howells <dhowells@redhat.com>
Mon, 19 Oct 2015 10:20:28 +0000 (11:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 20 Dec 2017 09:01:28 +0000 (10:01 +0100)
commit337cde8f541783dbc7fb0f974cd82798ba77794c
tree1525bd7eb822dfb986f906c659db49e33fc04e67
parentbd154dc611b343418d45753c3e101492a7ca13fa
KEYS: Don't permit request_key() to construct a new keyring

commit 911b79cde95c7da0ec02f48105358a36636b7a71 upstream.

If request_key() is used to find a keyring, only do the search part - don't
do the construction part if the keyring was not found by the search.  We
don't really want keyrings in the negative instantiated state since the
rejected/negative instantiation error value in the payload is unioned with
keyring metadata.

Now the kernel gives an error:

request_key("keyring", "#selinux,bdekeyring", "keyring", KEY_SPEC_USER_SESSION_KEYRING) = -1 EPERM (Operation not permitted)

Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
security/keys/request_key.c