]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
platform: don't return 0 from platform_get_irq[_byname]() on error
authorSergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Sun, 3 Jul 2016 22:04:24 +0000 (01:04 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 28 Oct 2016 07:45:19 +0000 (03:45 -0400)
commit33fe037cdcac990dffabac804982c9f2e1551888
treed8eb5c42e51763ae75a94f9929636b9e106aa5a0
parentbf07d2609f57a56e9a401c4c10cb83b7eca44bcc
platform: don't return 0 from platform_get_irq[_byname]() on error

commit e330b9a6bb35dc7097a4f02cb1ae7b6f96df92af upstream.

of_irq_get[_byname]() return 0 iff  irq_create_of_mapping() call fails.
Returning both  error code and 0 on failure is a sign of a misdesigned API,
it makes the failure check unnecessarily complex and error prone. We should
rely  on the platform IRQ resource in this case, not return 0,  especially
as 0 can be  a valid  IRQ resource too...

Fixes: aff008ad813c ("platform_get_irq: Revert to platform_get_resource if of_irq_get fails")
Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/platform.c