]> git.ipfire.org Git - thirdparty/openembedded/openembedded-core-contrib.git/commit
recipetool: create: do not treat numbers in SCM URLs as versions
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Mon, 6 Feb 2017 20:45:42 +0000 (09:45 +1300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 7 Feb 2017 14:48:55 +0000 (14:48 +0000)
commit3427508b6ce865654f8bf01a6fc04b83c70315d3
treec24c13fd4fd1e7b05917e3923cc048ab069c9c3a
parent2b66cb9982d10ce1744d430858eaef3e5a72c8c0
recipetool: create: do not treat numbers in SCM URLs as versions

Numbers within SCM (e.g. git) URLs are extremely unlikely to be valid
version numbers - more likely they are just part of the name, thus don't
try to extract them and use them as the version - doing so causes pretty
bad behaviour within devtool:

--------- snip ---------
$ devtool add https://github.com/inhedron/libtr50
NOTE: Fetching git://github.com/inhedron/libtr50;protocol=https...
...
NOTE: Using default source tree path .../build/workspace/sources/libtr
...
RecursionError: maximum recursion depth exceeded while calling a Python object
--------- snip ---------

(This was because ${PV} was being substituted into the URL, but PV's
value was being set to include ${SRCPV}, so there was a circular
reference.)

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/recipetool/create.py