]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls
authorMarc Kleine-Budde <mkl@pengutronix.de>
Fri, 2 May 2025 14:13:44 +0000 (16:13 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 18 May 2025 06:24:04 +0000 (08:24 +0200)
commit3482037d0f66cc4ce40e0332fa94ac73b9915de1
tree2b77a4c7b7ca8112a42e08d1335181ec80c6544b
parent73dde269a1a43e6b1aa92eba13ad2df58bfdd38e
can: mcp251xfd: mcp251xfd_remove(): fix order of unregistration calls

commit 84f5eb833f53ae192baed4cfb8d9eaab43481fc9 upstream.

If a driver is removed, the driver framework invokes the driver's
remove callback. A CAN driver's remove function calls
unregister_candev(), which calls net_device_ops::ndo_stop further down
in the call stack for interfaces which are in the "up" state.

With the mcp251xfd driver the removal of the module causes the
following warning:

| WARNING: CPU: 0 PID: 352 at net/core/dev.c:7342 __netif_napi_del_locked+0xc8/0xd8

as can_rx_offload_del() deletes the NAPI, while it is still active,
because the interface is still up.

To fix the warning, first unregister the network interface, which
calls net_device_ops::ndo_stop, which disables the NAPI, and then call
can_rx_offload_del().

Fixes: 55e5b97f003e ("can: mcp25xxfd: add driver for Microchip MCP25xxFD SPI CAN")
Cc: stable@vger.kernel.org
Link: https://patch.msgid.link/20250502-can-rx-offload-del-v1-1-59a9b131589d@pengutronix.de
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/can/spi/mcp251xfd/mcp251xfd-core.c