]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
comedi: jr3_pci: Fix synchronous deletion of timer
authorIan Abbott <abbotti@mev.co.uk>
Tue, 15 Apr 2025 12:39:01 +0000 (13:39 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 2 May 2025 05:39:29 +0000 (07:39 +0200)
commit348adceb91b2adf888599d2cc5f95b68b09f7008
treeda40d1eb98906f06db26ab5cabcb4c13b19386c8
parent6ac5fdd8ec0ec00388666899ace6f1f8e41f8297
comedi: jr3_pci: Fix synchronous deletion of timer

commit 44d9b3f584c59a606b521e7274e658d5b866c699 upstream.

When `jr3_pci_detach()` is called during device removal, it calls
`timer_delete_sync()` to stop the timer, but the timer expiry function
always reschedules the timer, so the synchronization is ineffective.

Call `timer_shutdown_sync()` instead.  It does not matter that the timer
expiry function pointer is cleared, because the device is being removed.

Fixes: 07b509e6584a5 ("Staging: comedi: add jr3_pci driver")
Cc: stable <stable@kernel.org>
Signed-off-by: Ian Abbott <abbotti@mev.co.uk>
Link: https://lore.kernel.org/r/20250415123901.13483-1-abbotti@mev.co.uk
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/jr3_pci.c