]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: fix qgroup reservation leak on failure to allocate ordered extent
authorFilipe Manana <fdmanana@suse.com>
Wed, 7 May 2025 12:05:36 +0000 (13:05 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Jul 2025 14:03:12 +0000 (16:03 +0200)
commit3499dcb6c507d378b1b75ff40d602da6e1991b8d
tree1c1b41098dcd3e3046b88c3009a3e002efed19fe
parentccdd3eaec689cc166f18ae9d091a570d291bbacb
btrfs: fix qgroup reservation leak on failure to allocate ordered extent

[ Upstream commit 1f2889f5594a2bc4c6a52634c4a51b93e785def5 ]

If we fail to allocate an ordered extent for a COW write we end up leaking
a qgroup data reservation since we called btrfs_qgroup_release_data() but
we didn't call btrfs_qgroup_free_refroot() (which would happen when
running the respective data delayed ref created by ordered extent
completion or when finishing the ordered extent in case an error happened).

So make sure we call btrfs_qgroup_free_refroot() if we fail to allocate an
ordered extent for a COW write.

Fixes: 7dbeaad0af7d ("btrfs: change timing for qgroup reserved space for ordered extents to fix reserved space leak")
CC: stable@vger.kernel.org # 6.1+
Reviewed-by: Boris Burkov <boris@bur.io>
Reviewed-by: Qu Wenruo <wqu@suse.com>
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/ordered-data.c