]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Don't use abort(3) in libpq's fe-print.c.
authorTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Jun 2021 18:17:42 +0000 (14:17 -0400)
committerTom Lane <tgl@sss.pgh.pa.us>
Mon, 28 Jun 2021 18:17:42 +0000 (14:17 -0400)
commit34c24e5a4337abf9d385558f6beaafb92d3a919d
tree9fc4fae6be0238d7c0c51640dde7a89e680392af
parentc62c3769ff6134f442c9acb623be4a0d4b17ca11
Don't use abort(3) in libpq's fe-print.c.

Causing a core dump on out-of-memory seems pretty unfriendly,
and surely is far outside the expected behavior of a general-purpose
library.  Just print an error message (as we did already) and return.
These functions unfortunately don't have an error return convention,
but code using them is probably just looking for a quick-n-dirty
print method and wouldn't bother to check anyway.

Although these functions are semi-deprecated, it still seems
appropriate to back-patch this.  In passing, also back-patch
b90e6cef1, just to reduce cosmetic differences between the
branches.

Discussion: https://postgr.es/m/3122443.1624735363@sss.pgh.pa.us
src/interfaces/libpq/fe-print.c