]> git.ipfire.org Git - thirdparty/tor.git/commit
Fix: don't report timeout when closing parallel intro points
authorDavid Goulet <dgoulet@ev0ke.net>
Mon, 10 Nov 2014 19:38:53 +0000 (14:38 -0500)
committerDavid Goulet <dgoulet@ev0ke.net>
Mon, 10 Nov 2014 20:02:54 +0000 (15:02 -0500)
commit34eb007d2201bad44bd6b72681f2c3552445dfc4
tree785412fba2f69c61a785c3415191557760f8856b
parentfed78bce8bc645866578a1739a10ee598bbaf4e0
Fix: don't report timeout when closing parallel intro points

When closing parallel introduction points, the given reason (timeout)
was actually changed to "no reason" thus when the circuit purpose was
CIRCUIT_PURPOSE_C_INTRODUCE_ACK_WAIT, we were reporting an introduction
point failure and flagging it "unreachable". After three times, that
intro point gets removed from the rend cache object.

In the case of CIRCUIT_PURPOSE_C_INTRODUCING, the intro point was
flagged has "timed out" and thus not used until the connection to the HS
is closed where that flag gets reset.

This commit adds an internal circuit reason called
END_CIRC_REASON_IP_NOW_REDUNDANT which tells the closing circuit
mechanism to not report any intro point failure.

This has been observed while opening hundreds of connections to an HS on
different circuit for each connection. This fix makes this use case to
work like a charm.

Fixes #13698.

Signed-off-by: David Goulet <dgoulet@ev0ke.net>
changes/bug13698 [new file with mode: 0644]
src/or/circuitlist.c
src/or/or.h
src/or/rendclient.c