]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
netpoll: Use rcu_access_pointer() in netpoll_poll_lock
authorBreno Leitao <leitao@debian.org>
Mon, 18 Nov 2024 11:15:18 +0000 (03:15 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 5 Dec 2024 12:53:28 +0000 (13:53 +0100)
commit34f2c041cb596f0ca859c59694620654ee9a09b6
tree8f929f78598746c63de137f0e5efbc1cbb6981b5
parent9b2f33b6046cbdcd19246fdea1292b53d2203b70
netpoll: Use rcu_access_pointer() in netpoll_poll_lock

[ Upstream commit a57d5a72f8dec7db8a79d0016fb0a3bdecc82b56 ]

The ndev->npinfo pointer in netpoll_poll_lock() is RCU-protected but is
being accessed directly for a NULL check. While no RCU read lock is held
in this context, we should still use proper RCU primitives for
consistency and correctness.

Replace the direct NULL check with rcu_access_pointer(), which is the
appropriate primitive when only checking for NULL without dereferencing
the pointer. This function provides the necessary ordering guarantees
without requiring RCU read-side protection.

Fixes: bea3348eef27 ("[NET]: Make NAPI polling independent of struct net_device objects.")
Signed-off-by: Breno Leitao <leitao@debian.org>
Reviewed-by: Michal Kubiak <michal.kubiak@intel.com>
Link: https://patch.msgid.link/20241118-netpoll_rcu-v1-2-a1888dcb4a02@debian.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
include/linux/netpoll.h