]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
accel/rocket: fix unwinding in error path in rocket_probe
authorQuentin Schulz <quentin.schulz@cherry.de>
Mon, 15 Dec 2025 16:36:15 +0000 (17:36 +0100)
committerTomeu Vizoso <tomeu@tomeuvizoso.net>
Sat, 10 Jan 2026 16:49:14 +0000 (17:49 +0100)
commit34f4495a7f72895776b81969639f527c99eb12b9
treee2b773542626ad7cc2af8f74069b9894b93896e0
parentf509a081f6a289f7c66856333b3becce7a33c97e
accel/rocket: fix unwinding in error path in rocket_probe

When rocket_core_init() fails (as could be the case with EPROBE_DEFER),
we need to properly unwind by decrementing the counter we just
incremented and if this is the first core we failed to probe, remove the
rocket DRM device with rocket_device_fini() as well. This matches the
logic in rocket_remove(). Failing to properly unwind results in
out-of-bounds accesses.

Fixes: 0810d5ad88a1 ("accel/rocket: Add job submission IOCTL")
Cc: stable@vger.kernel.org
Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
Reviewed-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Link: https://patch.msgid.link/20251215-rocket-error-path-v1-2-eec3bf29dc3b@cherry.de
drivers/accel/rocket/rocket_drv.c