]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tcp: xps: fix reordering issues
authorEric Dumazet <edumazet@google.com>
Thu, 23 May 2013 07:44:20 +0000 (07:44 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jun 2013 17:39:00 +0000 (10:39 -0700)
commit351cd36b0eae5cde8ca1fa7af89dfc14cc783b49
treec33dc68c522d5be9bb4277f44d68a097fee22f9c
parent0a76328a972feb3ee70a7918e7b5f23406543bff
tcp: xps: fix reordering issues

[ Upstream commit 547669d483e5783d722772af1483fa474da7caf9 ]

commit 3853b5841c01a ("xps: Improvements in TX queue selection")
introduced ooo_okay flag, but the condition to set it is slightly wrong.

In our traces, we have seen ACK packets being received out of order,
and RST packets sent in response.

We should test if we have any packets still in host queue.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Tom Herbert <therbert@google.com>
Cc: Yuchung Cheng <ycheng@google.com>
Cc: Neal Cardwell <ncardwell@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/ipv4/tcp_output.c