]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
PM: wakeup: Delete timer before removing wakeup source from list
authorKaushlendra Kumar <kaushlendra.kumar@intel.com>
Mon, 27 Oct 2025 04:41:27 +0000 (10:11 +0530)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Sat, 8 Nov 2025 11:17:28 +0000 (12:17 +0100)
commit352899fd911cafd16b3f41bb5c8585124dbd7f4b
tree51750e51e28ca5d31999ca0bacd9ad386bf7c8c3
parent39ce15a48f6730c8e53cc8fd0f63995a5e4bb239
PM: wakeup: Delete timer before removing wakeup source from list

Replace timer_delete_sync() with timer_shutdown_sync() and move
it before list_del_rcu() in wakeup_source_remove() to improve the
cleanup ordering and code clarity.

This ensures that the timer is stopped before removing the wakeup
source from the events list, providing a more logical cleanup
sequence.

While the current ordering is functionally correct, stopping the
timer first makes the cleanup flow more intuitive and follows the
general pattern of disabling active components before removing data
structures.

Signed-off-by: Kaushlendra Kumar <kaushlendra.kumar@intel.com>
[ rjw: Subject and changelog edits ]
Link: https://patch.msgid.link/20251027044127.2456365-1-kaushlendra.kumar@intel.com
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/base/power/wakeup.c