]> git.ipfire.org Git - thirdparty/linux.git/commit
pinctrl: single: fix refcount leak in pcs_add_gpio_func()
authorWei Li <unsw.weili@gmail.com>
Tue, 20 Jan 2026 08:07:35 +0000 (08:07 +0000)
committerLinus Walleij <linusw@kernel.org>
Tue, 3 Feb 2026 00:30:59 +0000 (01:30 +0100)
commit353353309b0f7afa407df29e455f9d15b5acc296
tree1e360cde0a25c9973dcfb7376ce9c6f74670083d
parente56aa18eba32fb68ac5e19e44670010095bb189c
pinctrl: single: fix refcount leak in pcs_add_gpio_func()

of_parse_phandle_with_args() returns a device_node pointer with refcount
incremented in gpiospec.np. The loop iterates through all phandles but
never releases the reference, causing a refcount leak on each iteration.

Add of_node_put() calls to release the reference after extracting the
needed arguments and on the error path when devm_kzalloc() fails.

This bug was detected by our static analysis tool and verified by my
code review.

Fixes: a1a277eb76b3 ("pinctrl: single: create new gpio function range")
Signed-off-by: Wei Li <unsw.weili@gmail.com>
Signed-off-by: Linus Walleij <linusw@kernel.org>
drivers/pinctrl/pinctrl-single.c