]> git.ipfire.org Git - thirdparty/libvirt.git/commit
tests: Fix syntax in iSCSI auth/secret tests
authorJohn Ferlan <jferlan@redhat.com>
Sat, 16 Apr 2016 12:11:00 +0000 (08:11 -0400)
committerCole Robinson <crobinso@redhat.com>
Wed, 20 Apr 2016 13:30:59 +0000 (09:30 -0400)
commit35351d5217e2efcca9f03bf197ebe16e5a7105b4
tree86a313120b311ef543f8dfa59fbe794c2bfc5d15
parent791c90cb8d0596939e275b52656c383e9c9b63c2
tests: Fix syntax in iSCSI auth/secret tests

While working on the tests for the secret initialization vector, I found
that the existing iSCSI tests were lacking in how they defined the IQN.
Many had IQN's of just 'iqn.1992-01.com.example' for one disk while using
'iqn.1992-01.com.example/1' for the second disk (same for hostdevs - guess
how they were copied/generated).

Typically (and documented this way), IQN's would include be of the form
'iqn.1992-01.com.example:storage/1' indicating an IQN using "storage" for
naming authority specific string and "/1" for the iSCSI LUN.

So modify the input XML's to use the more proper format - this of course
has a ripple effect on the output XML and the args.

Also note that the "%3A" is generated by the virURIFormat/xmlSaveUri
to represent the colon.

Signed-off-by: John Ferlan <jferlan@redhat.com>
(cherry picked from commit dd1400280eb0fcd38906b17a9341ac9fe6317498)
tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi-auth.args
tests/qemuargv2xmldata/qemuargv2xml-disk-drive-network-iscsi-auth.xml
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth.args
tests/qemuxml2argvdata/qemuxml2argv-disk-drive-network-iscsi-auth.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-lsi-iscsi-auth.xml
tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.args
tests/qemuxml2argvdata/qemuxml2argv-hostdev-scsi-virtio-iscsi-auth.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-disk-drive-network-iscsi-auth.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-lsi-iscsi-auth.xml
tests/qemuxml2xmloutdata/qemuxml2xmlout-hostdev-scsi-virtio-iscsi-auth.xml