]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
HID: wacom: Support sequence numbers smaller than 16-bit
authorJason Gerecke <jason.gerecke@wacom.com>
Mon, 9 Sep 2024 20:32:07 +0000 (13:32 -0700)
committerJiri Kosina <jkosina@suse.com>
Tue, 10 Sep 2024 21:47:03 +0000 (23:47 +0200)
commit359673ea3a203611b4f6d0f28922a4b9d2cfbcc8
treee122ae4c3f38794258456ff2fb0159891877ee43
parent19591e1a8a2e9e8ff53cc3121e6650bbf02f8403
HID: wacom: Support sequence numbers smaller than 16-bit

The current dropped packet reporting assumes that all sequence numbers
are 16 bits in length. This results in misleading "Dropped" messages if
the hardware uses fewer bits. For example, if a tablet uses only 8 bits
to store its sequence number, once it rolls over from 255 -> 0, the
driver will still be expecting a packet "256". This patch adjusts the
logic to reset the next expected packet to logical_minimum whenever
it overflows beyond logical_maximum.

Signed-off-by: Jason Gerecke <jason.gerecke@wacom.com>
Tested-by: Joshua Dickens <joshua.dickens@wacom.com>
Fixes: 6d09085b38e5 ("HID: wacom: Adding Support for new usages")
Signed-off-by: Jiri Kosina <jkosina@suse.com>
drivers/hid/wacom_wac.c