]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]
authorColin Ian King <colin.king@canonical.com>
Tue, 23 Feb 2021 19:38:21 +0000 (19:38 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 22 May 2021 08:38:22 +0000 (10:38 +0200)
commit35cc21c271055f777e6d2ddf3edaacbc0bca320b
treed263a47290508698d5c80913f01819c8660ea8d0
parent304e474ebc9914b0ee0db8818992731a799386e4
memory: gpmc: fix out of bounds read and dereference on gpmc_cs[]

[ Upstream commit e004c3e67b6459c99285b18366a71af467d869f5 ]

Currently the array gpmc_cs is indexed by cs before it cs is range checked
and the pointer read from this out-of-index read is dereferenced. Fix this
by performing the range check on cs before the read and the following
pointer dereference.

Addresses-Coverity: ("Negative array index read")
Fixes: 9ed7a776eb50 ("ARM: OMAP2+: Fix support for multiple devices on a GPMC chip select")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Tony Lindgren <tony@atomide.com>
Link: https://lore.kernel.org/r/20210223193821.17232-1-colin.king@canonical.com
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/memory/omap-gpmc.c